fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-03-19 17:10:50 +00:00
Code Issues Projects Releases Wiki Activity

removed support for REDIS_HELGRIND_FRIENDLY since Helgrind 3.5.0 is friendly enough even with many threads created and destroyed

Browse Source
This commit is contained in:
antirez 2010-01-16 07:57:32 -05:00
parent a9158272c6
commit 76a41fb163
1 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
redis.c
View File

@ -75,11 +75,6 @@
#include "lzf.h" /* LZF compression library */ #include "lzf.h" /* LZF compression library */
#include "pqsort.h" /* Partial qsort for SORT+LIMIT */ #include "pqsort.h" /* Partial qsort for SORT+LIMIT */
/* #define REDIS_HELGRIND_FRIENDLY */
#if defined(__GNUC__) && defined(REDIS_HELGRIND_FRIENDLY)
#warning "Remember to undef REDIS_HELGRIND_FRIENDLY before to commit"
#endif
/* Error codes */ /* Error codes */
#define REDIS_OK 0 #define REDIS_OK 0
#define REDIS_ERR -1 #define REDIS_ERR -1
@ -7710,15 +7705,6 @@ static void *IOThreadEntryPoint(void *arg) {
/* Get a new job to process */ /* Get a new job to process */
lockThreadedIO(); lockThreadedIO();
if (listLength(server.io_newjobs) == 0) { if (listLength(server.io_newjobs) == 0) {
#ifdef REDIS_HELGRIND_FRIENDLY
/* No new jobs? Wait and retry, because to be Helgrind
* (valgrind --tool=helgrind) what's needed is to take
* the same threads running instead to create/destroy threads
* as needed (otherwise valgrind will fail) */
unlockThreadedIO();
usleep(1); /* Give some time for the I/O thread to work. */
continue;
#endif
/* No new jobs in queue, exit. */ /* No new jobs in queue, exit. */
redisLog(REDIS_DEBUG,"Thread %lld exiting, nothing to do", redisLog(REDIS_DEBUG,"Thread %lld exiting, nothing to do",
(long long) pthread_self()); (long long) pthread_self());