From 76a41fb163b6e38845323e2b6a1269a31552c260 Mon Sep 17 00:00:00 2001 From: antirez Date: Sat, 16 Jan 2010 07:57:32 -0500 Subject: [PATCH] removed support for REDIS_HELGRIND_FRIENDLY since Helgrind 3.5.0 is friendly enough even with many threads created and destroyed --- redis.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/redis.c b/redis.c index 9484b75a..aed49ed8 100644 --- a/redis.c +++ b/redis.c @@ -75,11 +75,6 @@ #include "lzf.h" /* LZF compression library */ #include "pqsort.h" /* Partial qsort for SORT+LIMIT */ -/* #define REDIS_HELGRIND_FRIENDLY */ -#if defined(__GNUC__) && defined(REDIS_HELGRIND_FRIENDLY) -#warning "Remember to undef REDIS_HELGRIND_FRIENDLY before to commit" -#endif - /* Error codes */ #define REDIS_OK 0 #define REDIS_ERR -1 @@ -7710,15 +7705,6 @@ static void *IOThreadEntryPoint(void *arg) { /* Get a new job to process */ lockThreadedIO(); if (listLength(server.io_newjobs) == 0) { -#ifdef REDIS_HELGRIND_FRIENDLY - /* No new jobs? Wait and retry, because to be Helgrind - * (valgrind --tool=helgrind) what's needed is to take - * the same threads running instead to create/destroy threads - * as needed (otherwise valgrind will fail) */ - unlockThreadedIO(); - usleep(1); /* Give some time for the I/O thread to work. */ - continue; -#endif /* No new jobs in queue, exit. */ redisLog(REDIS_DEBUG,"Thread %lld exiting, nothing to do", (long long) pthread_self());