fluencelabs/marine
1
0
Fork 0
mirror of https://github.com/fluencelabs/marine.git synced 2025-03-15 14:00:50 +00:00
Code Issues Projects Releases Wiki Activity
marine/docs/developer-notes.md
Mike Voronov 7c793917cf
Add developer notes about PR reviewing (#157)
2022-04-26 16:20:02 +03:00

478 B
Raw Permalink Blame History

In the Marine we use the following conventions for PR reviewing:

  • Concept ACK - agree with the idea and overall concept, but haven't reviewed the code changes or tested them,
  • utACK (untested ACK) - reviewed and agree with the code changes but haven't actually tested them,
  • Tested ACK - reviewed the code changes and have verified the functionality or a bug fix,
  • NACK - disagree with the code changes/concept, should be accompanied by an explanation.