fluencelabs/aquavm
1
0
Fork 0
mirror of https://github.com/fluencelabs/aquavm synced 2025-03-15 12:30:50 +00:00
Code Issues Projects Releases Wiki Activity
aquavm/docs/developer-notes.md
Mike Voronov b23f1076ea
Add developer notes about PR reviewing (#255)
2022-04-26 16:22:15 +03:00

476 B
Raw Blame History

In the AquaVM we use the following conventions for PR reviewing:

  • Concept ACK - agree with the idea and overall concept, but haven't reviewed the code changes or tested them,
  • utACK (untested ACK) - reviewed and agree with the code changes but haven't actually tested them,
  • Tested ACK - reviewed the code changes and have verified the functionality or a bug fix,
  • NACK - disagree with the code changes/concept, should be accompanied by an explanation.