fluencelabs/wasmer
1
0
Fork 0
mirror of https://github.com/fluencelabs/wasmer synced 2025-03-30 22:41:03 +00:00
Code Issues Projects Releases Wiki Activity

rm REVIEW comments

Browse Source
This commit is contained in:
Mark McCaskey 2019-03-25 10:16:43 -07:00
parent c522c6d1e3
commit e56dfe70c7
2 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/emscripten/src/io/unix.rs
View File

@ -37,7 +37,6 @@ pub fn getprotobynumber(_ctx: &mut Ctx, _one: i32) -> i32 {
0 0
} }
// REVIEW: does this belong here?
/// getpwuid /// getpwuid
pub fn getpwuid(_ctx: &mut Ctx, _uid: i32) -> i32 { pub fn getpwuid(_ctx: &mut Ctx, _uid: i32) -> i32 {
debug!("emscripten::getpwuid"); debug!("emscripten::getpwuid");

2
lib/emscripten/src/syscalls/unix.rs
View File

@ -131,7 +131,6 @@ pub fn ___syscall77(ctx: &mut Ctx, _which: c_int, mut varargs: VarArgs) -> c_int
let rusage_ptr: c_int = varargs.get(ctx); let rusage_ptr: c_int = varargs.get(ctx);
#[allow(clippy::cast_ptr_alignment)] #[allow(clippy::cast_ptr_alignment)]
let rusage = emscripten_memory_pointer!(ctx.memory(0), rusage_ptr) as *mut rusage; let rusage = emscripten_memory_pointer!(ctx.memory(0), rusage_ptr) as *mut rusage;
// REVIEW: is this the correct way to verify alignment?
assert_eq!(8, mem::align_of_val(&rusage)); assert_eq!(8, mem::align_of_val(&rusage));
unsafe { getrusage(resource, rusage) } unsafe { getrusage(resource, rusage) }
} }
@ -180,7 +179,6 @@ pub fn ___syscall205(ctx: &mut Ctx, _which: c_int, mut varargs: VarArgs) -> c_in
#[allow(clippy::cast_ptr_alignment)] #[allow(clippy::cast_ptr_alignment)]
let gid_ptr = emscripten_memory_pointer!(ctx.memory(0), groups) as *mut gid_t; let gid_ptr = emscripten_memory_pointer!(ctx.memory(0), groups) as *mut gid_t;
// REVIEW: is this how we should verify allignment?
assert_eq!(4, mem::align_of_val(&gid_ptr)); assert_eq!(4, mem::align_of_val(&gid_ptr));
let result = unsafe { getgroups(ngroups_max, gid_ptr) }; let result = unsafe { getgroups(ngroups_max, gid_ptr) };
debug!( debug!(