fluencelabs/wasm-bindgen
1
0
Fork 0
mirror of https://github.com/fluencelabs/wasm-bindgen synced 2025-03-16 02:00:51 +00:00
Code Issues Projects Releases Wiki Activity

Only generate JS null checks in debug mode

Browse Source 
In non-debug mode Rust is already checking these pointers, so let's only
generate the relevant code in debug mode.
This commit is contained in:
Alex Crichton 2018-09-21 15:17:19 -07:00
parent 727cfc3bb5
commit ab3688d01a
4 changed files with 14 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crates/backend/src/codegen.rs
View File

@ -985,7 +985,7 @@ impl ToTokens for ast::Enum {
_extra: &mut ::wasm_bindgen::convert::Stack,
) -> Self {
#(#cast_clauses else)* {
::wasm_bindgen::throw("invalid enum value passed")
::wasm_bindgen::throw_str("invalid enum value passed")
}
}
}

12
crates/cli-support/src/js/js2rust.rs
View File

@ -68,11 +68,13 @@ impl<'a, 'b> Js2Rust<'a, 'b> {
/// passed should be `this.ptr`.
pub fn method(&mut self, method: bool, consumed: bool) -> &mut Self {
if method {
self.prelude(
"if (this.ptr === 0) {
throw new Error('Attempt to use a moved value');
}",
);
if self.cx.config.debug {
self.prelude(
"if (this.ptr === 0) {
throw new Error('Attempt to use a moved value');
}",
);
}
if consumed {
self.prelude(
"\

3
tests/wasm/imports.js
View File

@ -85,7 +85,8 @@ exports.custom_type_return_2 = function() {
};
exports.touch_custom_type = function() {
assert.throws(() => CUSTOM_TYPE.touch(), /Attempt to use a moved value/);
assert.throws(() => CUSTOM_TYPE.touch(),
/Attempt to use a moved value|null pointer passed to rust/);
};
exports.interpret_2_as_custom_type = function() {

6
tests/wasm/validate_prt.js
View File

@ -5,14 +5,16 @@ const useMoved = () => {
const apple = new wasm.Fruit('apple');
apple.name();
wasm.eat(apple);
assert.throws(() => apple.name(), /Attempt to use a moved value/);
assert.throws(() => apple.name(),
/Attempt to use a moved value|null pointer passed to rust/);
};
const moveMoved = () => {
const pear = new wasm.Fruit('pear');
pear.name();
wasm.eat(pear);
assert.throws(() => wasm.eat(pear), /Attempt to use a moved value/);
assert.throws(() => wasm.eat(pear),
/Attempt to use a moved value|null pointer passed to rust/);
};
exports.js_works = () => {