fluencelabs/wasm-bindgen
1
0
Fork 0
mirror of https://github.com/fluencelabs/wasm-bindgen synced 2025-03-31 01:11:06 +00:00
Code Issues Projects Releases Wiki Activity

Take &str instead of String in argument fn

Browse Source
This commit is contained in:
Caio 2019-03-14 12:21:41 -03:00
parent 59c1b2a565
commit 91ea972c03
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
crates/cli-support/src/js/js2rust.rs
View File

@ -85,7 +85,7 @@ impl<'a, 'b> Js2Rust<'a, 'b> {
{ {
if let Some(arg_names) = opt_arg_names.into() { if let Some(arg_names) = opt_arg_names.into() {
for (arg, arg_name) in function.arguments.iter().zip(arg_names) { for (arg, arg_name) in function.arguments.iter().zip(arg_names) {
self.argument(arg, arg_name.clone())?; self.argument(arg, arg_name.as_str())?;
} }
} else { } else {
for arg in function.arguments.iter() { for arg in function.arguments.iter() {
@ -151,9 +151,9 @@ impl<'a, 'b> Js2Rust<'a, 'b> {
self self
} }
fn abi_arg(&mut self, opt_arg_name: Option<String>) -> String { fn abi_arg(&mut self, opt_arg_name: Option<&str>) -> String {
let ret = if let Some(x) = opt_arg_name { let ret = if let Some(x) = opt_arg_name {
x x.into()
} else { } else {
format!("arg{}", self.arg_idx) format!("arg{}", self.arg_idx)
}; };
@ -161,9 +161,9 @@ impl<'a, 'b> Js2Rust<'a, 'b> {
ret ret
} }
pub fn argument<I>(&mut self, arg: &Descriptor, opt_arg_name: I) -> Result<&mut Self, Error> pub fn argument<'c, I>(&mut self, arg: &Descriptor, opt_arg_name: I) -> Result<&mut Self, Error>
where where
I: Into<Option<String>>, I: Into<Option<&'c str>>,
{ {
let i = self.arg_idx; let i = self.arg_idx;
let name = self.abi_arg(opt_arg_name.into()); let name = self.abi_arg(opt_arg_name.into());