fluencelabs/wasm-bindgen
1
0
Fork 0
mirror of https://github.com/fluencelabs/wasm-bindgen synced 2025-04-25 14:12:13 +00:00
Code Issues Projects Releases Wiki Activity

Fix a bug using encodeInto truncating strings

Browse Source 
The last write accidentally wasn't accounted for in the returned length
of the string and we unfortunately don't have any test coverage of
`encodeInto` since it requires Firefox nightly right now (and doesn't
work in Node yet).

Closes #1436
This commit is contained in:
Alex Crichton 2019-04-11 07:25:27 -07:00
parent d3fbf707e1
commit 3906e4066d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crates/cli-support/src/js/mod.rs
View File

@ -1364,11 +1364,11 @@ impl<'a> Context<'a> {
while (true) {{ while (true) {{
const view = getUint8Memory().subarray(ptr + writeOffset, ptr + size); const view = getUint8Memory().subarray(ptr + writeOffset, ptr + size);
const {{ read, written }} = cachedTextEncoder.encodeInto(arg, view); const {{ read, written }} = cachedTextEncoder.encodeInto(arg, view);
writeOffset += written;
if (read === arg.length) {{ if (read === arg.length) {{
break; break;
}} }}
arg = arg.substring(read); arg = arg.substring(read);
writeOffset += written;
ptr = wasm.__wbindgen_realloc(ptr, size, size += arg.length * 3); ptr = wasm.__wbindgen_realloc(ptr, size, size += arg.length * 3);
}} }}
WASM_VECTOR_LEN = writeOffset; WASM_VECTOR_LEN = writeOffset;