Merge pull request #1492 from RReverser/function-new-with-args

Add bindings for `new Function(args, body)`
This commit is contained in:
Alex Crichton 2019-04-26 12:05:46 -05:00 committed by GitHub
commit 36c0a1347d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 2 deletions

View File

@ -987,6 +987,17 @@ extern "C" {
#[derive(Clone, Debug, PartialEq, Eq)]
pub type Function;
/// The `Function` constructor creates a new `Function` object. Calling the
/// constructor directly can create functions dynamically, but suffers from
/// security and similar (but far less significant) performance issues
/// similar to `eval`. However, unlike `eval`, the `Function` constructor
/// allows executing code in the global scope, prompting better programming
/// habits and allowing for more efficient code minification.
///
/// [MDN documentation](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function)
#[wasm_bindgen(constructor)]
pub fn new_with_args(args: &str, body: &str) -> Function;
/// The `Function` constructor creates a new `Function` object. Calling the
/// constructor directly can create functions dynamically, but suffers from
/// security and similar (but far less significant) performance issues

View File

@ -101,7 +101,7 @@ fn stringify_with_replacer() {
assert_eq!(output1, "{\"hello\":\"world\"}");
let replacer_func =
Function::new_no_args("return arguments[0] === 'hello' ? undefined : arguments[1]");
Function::new_with_args("key, value", "return key === 'hello' ? undefined : value");
let output2: String =
JSON::stringify_with_replacer(&JsValue::from(obj), &JsValue::from(replacer_func))
.unwrap()
@ -164,7 +164,7 @@ fn stringify_with_replacer_and_space() {
assert_eq!(output2, "{\n \"hello\": \"world\"\n}");
let replacer_func =
Function::new_no_args("return arguments[0] === 'hello' ? undefined : arguments[1]");
Function::new_with_args("key, value", "return key === 'hello' ? undefined : value");
let output3: String = JSON::stringify_with_replacer_and_space(
&JsValue::from(obj),
&JsValue::from(replacer_func),