fluencelabs/wasm-bindgen
1
0
Fork 0
mirror of https://github.com/fluencelabs/wasm-bindgen synced 2025-03-16 18:20:51 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #1020 from fitzgen/move-by-value-debug-asserts

Browse Source 
Only emit JS glue assertions for move arguments in debug mode
This commit is contained in:
Nick Fitzgerald 2018-11-08 15:37:41 -08:00 committed by GitHub
commit 227e836e04
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
crates/cli-support/src/js/js2rust.rs
View File

@ -85,7 +85,7 @@ impl<'a, 'b> Js2Rust<'a, 'b> {
if self.cx.config.debug {
self.prelude(
"if (this.ptr === 0) {
throw new Error('Attempt to use a moved value');
throw new Error('Attempt to use a moved value');
}",
);
}
@ -330,14 +330,26 @@ impl<'a, 'b> Js2Rust<'a, 'b> {
self.prelude(&format!(
"\
const ptr{i} = {arg}.ptr;\n\
if (ptr{i} === 0) {{
throw new Error('Attempt to use a moved value');
}}
{arg}.ptr = 0;\n\
",
",
i = i,
arg = name
));
if self.cx.config.debug {
self.prelude(&format!(
"\
if (ptr{i} === 0) {{
throw new Error('Attempt to use a moved value');
}}
",
i = i,
));
}
self.prelude(&format!(
"\
{arg}.ptr = 0;\n\
",
arg = name
));
self.rust_arguments.push(format!("ptr{}", i));
}
return Ok(self);

2
tests/wasm/classes.js
View File

@ -124,7 +124,7 @@ exports.js_readonly_fields = () => {
exports.js_double_consume = () => {
const r = new wasm.DoubleConsume();
assert.throws(() => r.consume(r), /Attempt to use a moved value/);
assert.throws(() => r.consume(r));
};