Merge pull request #715 from kraai/patch-1

Check that all errors are instances of Object
This commit is contained in:
Alex Crichton 2018-08-16 09:28:58 -07:00 committed by GitHub
commit 0a47a1f9e2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 5 additions and 0 deletions

View File

@ -8,6 +8,7 @@ fn range_error() {
let error = RangeError::new("out of range yo"); let error = RangeError::new("out of range yo");
assert!(error.is_instance_of::<RangeError>()); assert!(error.is_instance_of::<RangeError>());
assert!(error.is_instance_of::<Error>()); assert!(error.is_instance_of::<Error>());
assert!(error.is_instance_of::<Object>());
let base: &Error = error.as_ref(); let base: &Error = error.as_ref();
assert_eq!(JsValue::from(base.message()), "out of range yo"); assert_eq!(JsValue::from(base.message()), "out of range yo");

View File

@ -8,6 +8,7 @@ fn reference_error() {
let error = ReferenceError::new("bad reference, fool"); let error = ReferenceError::new("bad reference, fool");
assert!(error.is_instance_of::<ReferenceError>()); assert!(error.is_instance_of::<ReferenceError>());
assert!(error.is_instance_of::<Error>()); assert!(error.is_instance_of::<Error>());
assert!(error.is_instance_of::<Object>());
let base: &Error = error.as_ref(); let base: &Error = error.as_ref();
assert_eq!(JsValue::from(base.message()), "bad reference, fool"); assert_eq!(JsValue::from(base.message()), "bad reference, fool");

View File

@ -8,6 +8,7 @@ fn syntax_error() {
let error = SyntaxError::new("msg"); let error = SyntaxError::new("msg");
assert!(error.is_instance_of::<SyntaxError>()); assert!(error.is_instance_of::<SyntaxError>());
assert!(error.is_instance_of::<Error>()); assert!(error.is_instance_of::<Error>());
assert!(error.is_instance_of::<Object>());
let base: &Error = error.as_ref(); let base: &Error = error.as_ref();
assert_eq!(JsValue::from(base.message()), "msg"); assert_eq!(JsValue::from(base.message()), "msg");

View File

@ -8,6 +8,7 @@ fn type_error() {
let error = TypeError::new("msg"); let error = TypeError::new("msg");
assert!(error.is_instance_of::<TypeError>()); assert!(error.is_instance_of::<TypeError>());
assert!(error.is_instance_of::<Error>()); assert!(error.is_instance_of::<Error>());
assert!(error.is_instance_of::<Object>());
let base: &Error = error.as_ref(); let base: &Error = error.as_ref();
assert_eq!(JsValue::from(base.message()), "msg"); assert_eq!(JsValue::from(base.message()), "msg");

View File

@ -8,6 +8,7 @@ fn uri_error() {
let error = UriError::new("msg"); let error = UriError::new("msg");
assert!(error.is_instance_of::<UriError>()); assert!(error.is_instance_of::<UriError>());
assert!(error.is_instance_of::<Error>()); assert!(error.is_instance_of::<Error>());
assert!(error.is_instance_of::<Object>());
let base: &Error = error.as_ref(); let base: &Error = error.as_ref();
assert_eq!(JsValue::from(base.message()), "msg"); assert_eq!(JsValue::from(base.message()), "msg");