fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-04-21 16:42:13 +00:00
Code Issues Projects Releases Wiki Activity

Don't over-allocate the sds string for large bulk requests.

Browse Source 
The call to sdsMakeRoomFor() did not accounted for the amount of data
already present in the query buffer, resulting into over-allocation.
This commit is contained in:
antirez 2013-08-27 11:54:38 +02:00
parent e21803348a
commit ff9d66c4a9
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/networking.c
View File

@ -989,13 +989,13 @@ int processMultibulkBuffer(redisClient *c) {
if (ll >= REDIS_MBULK_BIG_ARG) { if (ll >= REDIS_MBULK_BIG_ARG) {
/* If we are going to read a large object from network /* If we are going to read a large object from network
* try to make it likely that it will start at c->querybuf * try to make it likely that it will start at c->querybuf
* boundary so that we can optimized object creation * boundary so that we can optimize object creation
* avoiding a large copy of data. */ * avoiding a large copy of data. */
sdsrange(c->querybuf,pos,-1); sdsrange(c->querybuf,pos,-1);
pos = 0; pos = 0;
/* Hint the sds library about the amount of bytes this string is /* Hint the sds library about the amount of bytes this string is
* going to contain. */ * going to contain. */
c->querybuf = sdsMakeRoomFor(c->querybuf,ll+2); c->querybuf = sdsMakeRoomFor(c->querybuf,ll+2-sdslen(c->querybuf));
} }
c->bulklen = ll; c->bulklen = ll;
} }