fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-03-19 17:10:50 +00:00
Code Issues Projects Releases Wiki Activity

don't load value from VM for EXISTS

Browse Source
This commit is contained in:
Pieter Noordhuis 2010-05-07 11:40:26 +02:00
parent a0e7e5f516
commit f4f06efccc
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
TODO
View File

@ -15,7 +15,6 @@ Virtual Memory sub-TODO:
* Check if the page selection algorithm is working well * Check if the page selection algorithm is working well
* Divide swappability of objects by refcount * Divide swappability of objects by refcount
* Use multiple open FDs against the VM file, one for thread. * Use multiple open FDs against the VM file, one for thread.
* EXISTS should avoid loading the object if possible without making the code too specialized.
* vm-min-age <seconds> option * vm-min-age <seconds> option
* Make sure objects loaded from the VM are specially encoded when possible. * Make sure objects loaded from the VM are specially encoded when possible.
* Check what happens performance-wise if instead to create threads again and again the same threads are reused forever. Note: this requires a way to disable this clients in the child, but waiting for empty new jobs queue can be enough. * Check what happens performance-wise if instead to create threads again and again the same threads are reused forever. Note: this requires a way to disable this clients in the child, but waiting for empty new jobs queue can be enough.

7
redis.c
View File

@ -4343,7 +4343,12 @@ static void delCommand(redisClient *c) {
} }
static void existsCommand(redisClient *c) { static void existsCommand(redisClient *c) {
addReply(c,lookupKeyRead(c->db,c->argv[1]) ? shared.cone : shared.czero); expireIfNeeded(c->db,c->argv[1]);
if (dictFind(c->db->dict,c->argv[1])) {
addReply(c, shared.cone);
} else {
addReply(c, shared.czero);
}
} }
static void selectCommand(redisClient *c) { static void selectCommand(redisClient *c) {