From eb746ec40890f2edfcd6c05a099814cb96d2f448 Mon Sep 17 00:00:00 2001 From: antirez Date: Tue, 25 Mar 2014 17:50:46 +0100 Subject: [PATCH] Cluster: CLUSTER SETSLOT implementation comment updated. Update the comment since the implementation details changed. --- src/cluster.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/cluster.c b/src/cluster.c index 811a5207..fa226b98 100644 --- a/src/cluster.c +++ b/src/cluster.c @@ -3320,9 +3320,11 @@ void clusterCommand(redisClient *c) { * to a new epoch so that the new version can be propagated * by the cluster. * - * FIXME: the new version should be agreed otherwise a race - * is possible if while a manual resharding is in progress - * the master is failed over by a slave. */ + * Note that if this ever results in a collision with another + * node getting the same configEpoch, for example because a + * failover happens at the same time we close the slot, the + * configEpoch collision resolution will fix it assigning + * a different epoch to each node. */ uint64_t maxEpoch = clusterGetMaxEpoch(); if (myself->configEpoch == 0 ||