From eae8d0582638dcc5ffd686e3165faa05424b3f33 Mon Sep 17 00:00:00 2001 From: valentino Date: Mon, 5 Nov 2018 11:13:02 +0200 Subject: [PATCH] fix short period of server.hz being uninitialized server.hz was uninitialized between initServerConfig and initServer. this can lead to someone (e.g. queued modules) doing createObject, and accessing an uninitialized variable, that can potentially be 0, and lead to a crash. --- src/server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server.c b/src/server.c index f92a75b5..d0387306 100644 --- a/src/server.c +++ b/src/server.c @@ -1529,7 +1529,7 @@ void initServerConfig(void) { server.timezone = getTimeZone(); /* Initialized by tzset(). */ server.configfile = NULL; server.executable = NULL; - server.config_hz = CONFIG_DEFAULT_HZ; + server.hz = server.config_hz = CONFIG_DEFAULT_HZ; server.dynamic_hz = CONFIG_DEFAULT_DYNAMIC_HZ; server.arch_bits = (sizeof(long) == 8) ? 64 : 32; server.port = CONFIG_DEFAULT_SERVER_PORT;