From e819c2ef5b6f6b7c196cc7c00c543c4af8c703a7 Mon Sep 17 00:00:00 2001 From: antirez Date: Wed, 13 Feb 2019 16:30:44 +0100 Subject: [PATCH] ACL: tag LASTSAVE as dangerous. That's not REALLY needed, but... right now with LASTSAVE being the only command tagged as "admin" but not "dangerous" what happens is that after rewrites the rewrite engine will produce from the rules: user default on +@all ~* -@dangerous nopass The rewrite: user default on nopass ~* +@all -@admin -@dangerous +lastsave Which is correct but will have users wondering about why LASTSAVE has something special. Since LASTSAVE after all also leaks information about the underlying server configuration, that may not be great for SAAS vendors, let's tag it as dangerous as well and forget about this issue :-) --- src/server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server.c b/src/server.c index 1a6c277e..4adc7b67 100644 --- a/src/server.c +++ b/src/server.c @@ -658,7 +658,7 @@ struct redisCommand redisCommandTable[] = { 0,NULL,0,0,0,0,0,0}, {"lastsave",lastsaveCommand,1, - "read-only random fast @admin", + "read-only random fast @admin @dangerous", 0,NULL,0,0,0,0,0,0}, {"type",typeCommand,2,