fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-03-30 22:31:03 +00:00
Code Issues Projects Releases Wiki Activity

Return error to client on wrong type for HMGET

Browse Source
This commit is contained in:
Pieter Noordhuis 2010-10-26 12:26:27 +02:00
parent 244201f6ba
commit e584d82fec
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/t_hash.c
View File

@ -310,6 +310,7 @@ void hmgetCommand(redisClient *c) {
o = lookupKeyRead(c->db,c->argv[1]); o = lookupKeyRead(c->db,c->argv[1]);
if (o != NULL && o->type != REDIS_HASH) { if (o != NULL && o->type != REDIS_HASH) {
addReply(c,shared.wrongtypeerr); addReply(c,shared.wrongtypeerr);
return;
} }
/* Note the check for o != NULL happens inside the loop. This is /* Note the check for o != NULL happens inside the loop. This is

5
tests/unit/type/hash.tcl
View File

@ -140,6 +140,11 @@ start_server {tags {"hash"}} {
set _ $rv set _ $rv
} {{{} {}} {{} {}} {{} {}}} } {{{} {}} {{} {}} {{} {}}}
test {HMGET against wrong type} {
r set wrongtype somevalue
assert_error "*wrong*" {r hmget wrongtype field1 field2}
}
test {HMGET - small hash} { test {HMGET - small hash} {
set keys {} set keys {}
set vals {} set vals {}