fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-03-30 22:31:03 +00:00
Code Issues Projects Releases Wiki Activity

Modules: RM_HashSet() SDS ownership business clarified in comments.

Browse Source 
Related to #3239.
This commit is contained in:
antirez 2016-05-18 16:17:46 +02:00
parent 01a83d0a2a
commit e3edae957b
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/module.c
View File

@ -1788,18 +1788,18 @@ int RM_HashSet(RedisModuleKey *key, int flags, ...) {
continue; continue;
} }
int low_flags = HASH_SET_COPY;
/* If CFIELDS is active, we can pass the ownership of the /* If CFIELDS is active, we can pass the ownership of the
* SDS object to the low level function that sets the field * SDS object to the low level function that sets the field
* to avoid a useless copy. */ * to avoid a useless copy. */
int low_flags = HASH_SET_COPY;
if (flags & REDISMODULE_HASH_CFIELDS) if (flags & REDISMODULE_HASH_CFIELDS)
low_flags |= HASH_SET_TAKE_FIELD; low_flags |= HASH_SET_TAKE_FIELD;
updated += hashTypeSet(key->value, field->ptr, value->ptr, low_flags); updated += hashTypeSet(key->value, field->ptr, value->ptr, low_flags);
/* If CFIELDS is active, ownership is now of hashTypeSet() */ /* If CFIELDS is active, SDS string ownership is now of hashTypeSet(),
* however we still have to release the 'field' object shell. */
if (flags & REDISMODULE_HASH_CFIELDS) { if (flags & REDISMODULE_HASH_CFIELDS) {
field->ptr = NULL; field->ptr = NULL; /* Prevent the SDS string from being freed. */
/* Cleanup */
decrRefCount(field); decrRefCount(field);
} }
} }