fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-04-03 16:21:03 +00:00
Code Issues Projects Releases Wiki Activity

update the zipmap entry in-place instead of appending it

Browse Source
This commit is contained in:
Pieter Noordhuis 2010-04-01 14:02:22 +02:00
parent bfded2aa51
commit da2cfe8a3b
1 changed files with 20 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
zipmap.c
View File

@ -208,7 +208,7 @@ static inline unsigned char *zipmapResize(unsigned char *zm, unsigned int len) {
* If 'update' is not NULL, *update is set to 1 if the key was * If 'update' is not NULL, *update is set to 1 if the key was
* already preset, otherwise to 0. */ * already preset, otherwise to 0. */
unsigned char *zipmapSet(unsigned char *zm, unsigned char *key, unsigned int klen, unsigned char *val, unsigned int vlen, int *update) { unsigned char *zipmapSet(unsigned char *zm, unsigned char *key, unsigned int klen, unsigned char *val, unsigned int vlen, int *update) {
unsigned int zmlen; unsigned int zmlen, offset;
unsigned int freelen, reqlen = zipmapRequiredLength(klen,vlen); unsigned int freelen, reqlen = zipmapRequiredLength(klen,vlen);
unsigned int empty, vempty; unsigned int empty, vempty;
unsigned char *p; unsigned char *p;
@ -230,27 +230,34 @@ unsigned char *zipmapSet(unsigned char *zm, unsigned char *key, unsigned int kle
if (update) *update = 1; if (update) *update = 1;
freelen = zipmapRawEntryLength(p); freelen = zipmapRawEntryLength(p);
if (freelen < reqlen) { if (freelen < reqlen) {
/* Move remaining entries to the current position, so this /* Store the offset of this key within the current zipmap, so
* pair can be appended. Note: the +1 in memmove is caused * it can be resized. Then, move the tail backwards so this
* by the end-of-zipmap byte. */ * pair fits at the current position. */
memmove(p, p+freelen, zmlen-((p-zm)+freelen+1)); offset = p-zm;
zm = zipmapResize(zm, zmlen-freelen+reqlen); zm = zipmapResize(zm, zmlen-freelen+reqlen);
p = zm+zmlen-1-freelen; p = zm+offset;
zmlen = zmlen-1-freelen+reqlen;
/* The +1 in the number of bytes to be moved is caused by the
* end-of-zipmap byte. Note: the *original* zmlen is used. */
memmove(p+reqlen, p+freelen, zmlen-(offset+freelen+1));
zmlen = zmlen-freelen+reqlen;
freelen = reqlen; freelen = reqlen;
} }
} }
/* Ok we have a suitable block where to write the new key/value /* We now have a suitable block where the key/value entry can
* entry. */ * be written. If there is too much free space, move the tail
* of the zipmap a few bytes to the front and shrink the zipmap,
* as we want zipmaps to be very space efficient. */
empty = freelen-reqlen; empty = freelen-reqlen;
/* If there is too much free space mark it as a free block instead
* of adding it as trailing empty space for the value, as we want
* zipmaps to be very space efficient. */
if (empty >= ZIPMAP_VALUE_MAX_FREE) { if (empty >= ZIPMAP_VALUE_MAX_FREE) {
memmove(p+reqlen, p+freelen, zmlen-((p-zm)+freelen+1)); /* First, move the tail <empty> bytes to the front, then resize
* the zipmap to be <empty> bytes smaller. */
offset = p-zm;
memmove(p+reqlen, p+freelen, zmlen-(offset+freelen+1));
zmlen -= empty; zmlen -= empty;
zm = zipmapResize(zm, zmlen); zm = zipmapResize(zm, zmlen);
p = zm+offset;
vempty = 0; vempty = 0;
} else { } else {
vempty = empty; vempty = empty;