From d6410ed19a4930895f2591eed224d5ec5449393a Mon Sep 17 00:00:00 2001 From: antirez Date: Sat, 13 Dec 2014 08:57:06 +0100 Subject: [PATCH] Don't log admin commands in MONITOR. Otherwise there are security risks, especially when providing Redis as a service, the user may "sniff" for admin commands renamed to an unguessable string via rename-command in redis.conf. --- src/redis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/redis.c b/src/redis.c index 7c00e77a..0f0bc56c 100644 --- a/src/redis.c +++ b/src/redis.c @@ -2033,7 +2033,7 @@ void call(redisClient *c, int flags) { * not generated from reading an AOF. */ if (listLength(server.monitors) && !server.loading && - !(c->cmd->flags & REDIS_CMD_SKIP_MONITOR)) + !(c->cmd->flags & (REDIS_CMD_SKIP_MONITOR|REDIS_CMD_ADMIN))) { replicationFeedMonitors(c,server.monitors,c->db->id,c->argv,c->argc); }