fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-04-03 00:01:04 +00:00
Code Issues Projects Releases Wiki Activity

Cache uname() output across INFO calls.

Browse Source 
Uname was profiled to be a slow syscall. It produces always the same
output in the context of a single execution of Redis, so calling it at
every INFO output generation does not make too much sense.

The uname utsname structure was modified as a static variable. At the
same time a static integer was added to check if we need to call uname
the first time.
This commit is contained in:
antirez 2014-03-24 10:00:08 +01:00
parent a9caca0424
commit d3efe04c47
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/redis.c
View File

@ -2359,7 +2359,8 @@ sds genRedisInfoString(char *section) {
/* Server */ /* Server */
if (allsections || defsections || !strcasecmp(section,"server")) { if (allsections || defsections || !strcasecmp(section,"server")) {
struct utsname name; static int call_uname = 1;
static struct utsname name;
char *mode; char *mode;
if (server.cluster_enabled) mode = "cluster"; if (server.cluster_enabled) mode = "cluster";
@ -2367,7 +2368,13 @@ sds genRedisInfoString(char *section) {
else mode = "standalone"; else mode = "standalone";
if (sections++) info = sdscat(info,"\r\n"); if (sections++) info = sdscat(info,"\r\n");
if (call_uname) {
/* Uname can be slow and is always the same output. Cache it. */
uname(&name); uname(&name);
call_uname = 0;
}
info = sdscatprintf(info, info = sdscatprintf(info,
"# Server\r\n" "# Server\r\n"
"redis_version:%s\r\n" "redis_version:%s\r\n"