fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-04-03 16:21:03 +00:00
Code Issues Projects Releases Wiki Activity

Fixed a bug with replication where SLAVEOF NO ONE caused a slave to close the connection with its slaves

Browse Source
This commit is contained in:
antirez 2011-04-29 14:18:16 +02:00
parent c772d9c6e7
commit d37299e3b7
1 changed files with 10 additions and 4 deletions

8
src/networking.c

@ -526,12 +526,18 @@ void freeClient(redisClient *c) {
* close the connection with all our slaves if we have any, so * close the connection with all our slaves if we have any, so
* when we'll resync with the master the other slaves will sync again * when we'll resync with the master the other slaves will sync again
* with us as well. Note that also when the slave is not connected * with us as well. Note that also when the slave is not connected
* to the master it will keep refusing connections by other slaves. */ * to the master it will keep refusing connections by other slaves.
*
* We do this only if server.masterhost != NULL. If it is NULL this
* means the user called SLAVEOF NO ONE and we are freeing our
* link with the master, so no need to close link with slaves. */
if (server.masterhost != NULL) {
while (listLength(server.slaves)) { while (listLength(server.slaves)) {
ln = listFirst(server.slaves); ln = listFirst(server.slaves);
freeClient((redisClient*)ln->value); freeClient((redisClient*)ln->value);
} }
} }
}
/* Release memory */ /* Release memory */
zfree(c->argv); zfree(c->argv);
freeClientMultiState(c); freeClientMultiState(c);