fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-05-08 17:02:13 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #6257 from JohnSully/ModuleSecurity

Browse Source 
Modules must have execute permissions to load
This commit is contained in:
Salvatore Sanfilippo 2019-12-12 09:27:47 +01:00 committed by GitHub
commit c227f5e7bd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/module.c
View File

@ -31,6 +31,7 @@
#include "cluster.h" #include "cluster.h"
#include "rdb.h" #include "rdb.h"
#include <dlfcn.h> #include <dlfcn.h>
#include <sys/stat.h>
#include <sys/wait.h> #include <sys/wait.h>
/* -------------------------------------------------------------------------- /* --------------------------------------------------------------------------
@ -6985,6 +6986,15 @@ int moduleLoad(const char *path, void **module_argv, int module_argc) {
void *handle; void *handle;
RedisModuleCtx ctx = REDISMODULE_CTX_INIT; RedisModuleCtx ctx = REDISMODULE_CTX_INIT;
struct stat st;
if (stat(path, &st) == 0)
{ // this check is best effort
if (!(st.st_mode & (S_IXUSR | S_IXGRP | S_IXOTH))) {
serverLog(LL_WARNING, "Module %s failed to load: It does not have execute permissions.", path);
return C_ERR;
}
}
handle = dlopen(path,RTLD_NOW|RTLD_LOCAL); handle = dlopen(path,RTLD_NOW|RTLD_LOCAL);
if (handle == NULL) { if (handle == NULL) {
serverLog(LL_WARNING, "Module %s failed to load: %s", path, dlerror()); serverLog(LL_WARNING, "Module %s failed to load: %s", path, dlerror());