From c14ba46e3a725a2325d8d5fd90097b1c889de1e2 Mon Sep 17 00:00:00 2001 From: antirez Date: Tue, 13 Feb 2018 15:43:26 +0100 Subject: [PATCH] Make it explicit with a comment why we kill the old AOF rewrite. See #3858. --- src/aof.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/aof.c b/src/aof.c index 276a7c08..fdb72904 100644 --- a/src/aof.c +++ b/src/aof.c @@ -260,6 +260,9 @@ int startAppendOnly(void) { server.aof_rewrite_scheduled = 1; serverLog(LL_WARNING,"AOF was enabled but there is already a child process saving an RDB file on disk. An AOF background was scheduled to start when possible."); } else { + /* If there is a pending AOF rewrite, we need to switch it off and + * start a new one: the old one cannot be reused becuase it is not + * accumulating the AOF buffer. */ if (server.aof_child_pid != -1) { serverLog(LL_WARNING,"AOF was enabled but there is already an AOF rewriting in background. Stopping background AOF and starting a rewrite now."); killAppendOnlyChild();