fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-03-19 17:10:50 +00:00
Code Issues Projects Releases Wiki Activity

fix #5580, display fragmentation and rss overhead bytes as signed

Browse Source 
these metrics become negative when RSS is smaller than the used_memory.
This can easily happen when the program allocated a lot of memory and haven't
written to it yet, in which case the kernel doesn't allocate any pages to the process
This commit is contained in:
Oran Agra 2018-12-02 15:29:20 +02:00
parent 46a51cdcdc
commit b587c54c24
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/server.c
View File

@ -3247,11 +3247,11 @@ sds genRedisInfoString(char *section) {
"allocator_frag_ratio:%.2f\r\n" "allocator_frag_ratio:%.2f\r\n"
"allocator_frag_bytes:%zu\r\n" "allocator_frag_bytes:%zu\r\n"
"allocator_rss_ratio:%.2f\r\n" "allocator_rss_ratio:%.2f\r\n"
"allocator_rss_bytes:%zu\r\n" "allocator_rss_bytes:%zd\r\n"
"rss_overhead_ratio:%.2f\r\n" "rss_overhead_ratio:%.2f\r\n"
"rss_overhead_bytes:%zu\r\n" "rss_overhead_bytes:%zd\r\n"
"mem_fragmentation_ratio:%.2f\r\n" "mem_fragmentation_ratio:%.2f\r\n"
"mem_fragmentation_bytes:%zu\r\n" "mem_fragmentation_bytes:%zd\r\n"
"mem_not_counted_for_evict:%zu\r\n" "mem_not_counted_for_evict:%zu\r\n"
"mem_replication_backlog:%zu\r\n" "mem_replication_backlog:%zu\r\n"
"mem_clients_slaves:%zu\r\n" "mem_clients_slaves:%zu\r\n"

6
src/server.h
View File

@ -864,11 +864,11 @@ struct redisMemOverhead {
float dataset_perc; float dataset_perc;
float peak_perc; float peak_perc;
float total_frag; float total_frag;
size_t total_frag_bytes; ssize_t total_frag_bytes;
float allocator_frag; float allocator_frag;
size_t allocator_frag_bytes; ssize_t allocator_frag_bytes;
float allocator_rss; float allocator_rss;
size_t allocator_rss_bytes; ssize_t allocator_rss_bytes;
float rss_extra; float rss_extra;
size_t rss_extra_bytes; size_t rss_extra_bytes;
size_t num_dbs; size_t num_dbs;