From b507289750eb77b554847afa03da8eb044f49a3a Mon Sep 17 00:00:00 2001 From: antirez Date: Thu, 23 Jun 2016 09:38:30 +0200 Subject: [PATCH] Commit change in autoMemoryFreed(): first -> last. It's more natural to call the last entry added as "last", the original commet got me confused until I actually read the code. --- src/module.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/module.c b/src/module.c index d77a8f95..3bff4779 100644 --- a/src/module.c +++ b/src/module.c @@ -621,11 +621,12 @@ void autoMemoryFreed(RedisModuleCtx *ctx, int type, void *ptr) { { ctx->amqueue[i].type = REDISMODULE_AM_FREED; - /* Switch the freed element and the top element, to avoid growing + /* Switch the freed element and the last element, to avoid growing * the queue unnecessarily if we allocate/free in a loop */ if (i != ctx->amqueue_used-1) { ctx->amqueue[i] = ctx->amqueue[ctx->amqueue_used-1]; } + /* Reduce the size of the queue because we either moved the top * element elsewhere or freed it */ ctx->amqueue_used--;