fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-04-01 15:21:03 +00:00
Code Issues Projects Releases Wiki Activity

Return empty string if GETRANGE of empty string

Browse Source 
Previously, GETRANGE of a key containing nothing ("")
would allocate a large (size_t)-1 return value causing
crashes on 32bit builds when it tried to allocate the
4 GB return string.
This commit is contained in:
Matt Stancliff 2014-09-02 18:56:28 -04:00
parent f0e306f4a0
commit b20df972ed
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/t_string.c
View File

@ -259,7 +259,7 @@ void getrangeCommand(redisClient *c) {
/* Precondition: end >= 0 && end < strlen, so the only condition where /* Precondition: end >= 0 && end < strlen, so the only condition where
* nothing can be returned is: start > end. */ * nothing can be returned is: start > end. */
if (start > end) { if (start > end || strlen == 0) {
addReply(c,shared.emptybulk); addReply(c,shared.emptybulk);
} else { } else {
addReplyBulkCBuffer(c,(char*)str+start,end-start+1); addReplyBulkCBuffer(c,(char*)str+start,end-start+1);