fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-04-03 00:01:04 +00:00
Code Issues Projects Releases Wiki Activity

Increase string2ld's buffer size (and fix HINCRBYFLOAT)

Browse Source 
The string representation of `long double` may take
up to ~5000 chars (see PR #3745).

Before this fix HINCRBYFLOAT would never overflow (since
the string could not exceed 256 chars). Now it can.
This commit is contained in:
Guy Benoish 2019-01-28 17:58:11 +02:00
parent b270322ff9
commit b0c8d6c227
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/t_hash.c
View File

@ -615,6 +615,10 @@ void hincrbyfloatCommand(client *c) {
} }
value += incr; value += incr;
if (isnan(value) || isinf(value)) {
addReplyError(c,"increment would produce NaN or Infinity");
return;
}
char buf[MAX_LONG_DOUBLE_CHARS]; char buf[MAX_LONG_DOUBLE_CHARS];
int len = ld2string(buf,sizeof(buf),value,1); int len = ld2string(buf,sizeof(buf),value,1);

2
src/util.c
View File

@ -447,7 +447,7 @@ int string2l(const char *s, size_t slen, long *lval) {
* a double: no spaces or other characters before or after the string * a double: no spaces or other characters before or after the string
* representing the number are accepted. */ * representing the number are accepted. */
int string2ld(const char *s, size_t slen, long double *dp) { int string2ld(const char *s, size_t slen, long double *dp) {
char buf[256]; char buf[MAX_LONG_DOUBLE_CHARS];
long double value; long double value;
char *eptr; char *eptr;