fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-04-01 15:21:03 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #5119 from trevor211/fixSlowlogConfig

Browse Source 
Fix slowlog config
This commit is contained in:
Salvatore Sanfilippo 2018-07-13 17:35:15 +02:00 committed by GitHub
commit a44a59340c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/config.c
View File

@ -1122,7 +1122,7 @@ void configSetCommand(client *c) {
} config_set_numerical_field( } config_set_numerical_field(
"lua-time-limit",server.lua_time_limit,0,LONG_MAX) { "lua-time-limit",server.lua_time_limit,0,LONG_MAX) {
} config_set_numerical_field( } config_set_numerical_field(
"slowlog-log-slower-than",server.slowlog_log_slower_than,0,LLONG_MAX) { "slowlog-log-slower-than",server.slowlog_log_slower_than,-1,LLONG_MAX) {
} config_set_numerical_field( } config_set_numerical_field(
"slowlog-max-len",ll,0,LONG_MAX) { "slowlog-max-len",ll,0,LONG_MAX) {
/* Cast to unsigned. */ /* Cast to unsigned. */

2
src/latency.c
View File

@ -294,7 +294,7 @@ sds createLatencyReport(void) {
/* Potentially commands. */ /* Potentially commands. */
if (!strcasecmp(event,"command")) { if (!strcasecmp(event,"command")) {
if (server.slowlog_log_slower_than == 0) { if (server.slowlog_log_slower_than < 0) {
advise_slowlog_enabled = 1; advise_slowlog_enabled = 1;
advices++; advices++;
} else if (server.slowlog_log_slower_than/1000 > } else if (server.slowlog_log_slower_than/1000 >

10
tests/unit/slowlog.tcl
View File

@ -78,4 +78,14 @@ start_server {tags {"slowlog"} overrides {slowlog-log-slower-than 1000000}} {
set e [lindex [r slowlog get] 0] set e [lindex [r slowlog get] 0]
assert_equal {lastentry_client} [lindex $e 5] assert_equal {lastentry_client} [lindex $e 5]
} }
test {SLOWLOG - can be disabled} {
r config set slowlog-log-slower-than 1
r slowlog reset
assert_equal [r slowlog len] 1
r config set slowlog-log-slower-than -1
r slowlog reset
r debug sleep 0.2
assert_equal [r slowlog len] 0
}
} }