fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-04-04 16:51:12 +00:00
Code Issues Projects Releases Wiki Activity

SIGSEGV handler refactored so that we can reuse stack trace and current client logging functionalities in other contexts.

Browse Source
This commit is contained in:
antirez 2012-03-27 10:33:45 +02:00
parent ca09ad4d64
commit a323870450
1 changed files with 62 additions and 47 deletions

67
src/debug.c

@ -558,21 +558,11 @@ void logRegisters(ucontext_t *uc) {
#endif #endif
} }
void sigsegvHandler(int sig, siginfo_t *info, void *secret) { /* Logs the stack trace using the backtrace() call. */
void logStackTrace(ucontext_t *uc) {
void *trace[100]; void *trace[100];
char **messages = NULL;
int i, trace_size = 0; int i, trace_size = 0;
ucontext_t *uc = (ucontext_t*) secret; char **messages = NULL;
sds infostring, clients;
struct sigaction act;
REDIS_NOTUSED(info);
bugReportStart();
redisLog(REDIS_WARNING,
" Redis %s crashed by signal: %d", REDIS_VERSION, sig);
redisLog(REDIS_WARNING,
" Failed assertion: %s (%s:%d)", server.assert_failed,
server.assert_file, server.assert_line);
/* Generate the stack trace */ /* Generate the stack trace */
trace_size = backtrace(trace, 100); trace_size = backtrace(trace, 100);
@ -585,20 +575,14 @@ void sigsegvHandler(int sig, siginfo_t *info, void *secret) {
redisLog(REDIS_WARNING, "--- STACK TRACE"); redisLog(REDIS_WARNING, "--- STACK TRACE");
for (i=1; i<trace_size; ++i) for (i=1; i<trace_size; ++i)
redisLog(REDIS_WARNING,"%s", messages[i]); redisLog(REDIS_WARNING,"%s", messages[i]);
}
/* Log INFO and CLIENT LIST */ /* Log information about the "current" client, that is, the client that is
redisLog(REDIS_WARNING, "--- INFO OUTPUT"); * currently being served by Redis. May be NULL if Redis is not serving a
infostring = genRedisInfoString("all"); * client right now. */
infostring = sdscatprintf(infostring, "hash_init_value: %u\n", void logCurrentClient(void) {
dictGetHashFunctionSeed()); if (server.current_client == NULL) return;
redisLogRaw(REDIS_WARNING, infostring);
redisLog(REDIS_WARNING, "--- CLIENT LIST OUTPUT");
clients = getAllClientsInfoString();
redisLogRaw(REDIS_WARNING, clients);
/* Don't sdsfree() strings to avoid a crash. Memory may be corrupted. */
/* Log CURRENT CLIENT info */
if (server.current_client) {
redisClient *cc = server.current_client; redisClient *cc = server.current_client;
sds client; sds client;
int j; int j;
@ -606,7 +590,7 @@ void sigsegvHandler(int sig, siginfo_t *info, void *secret) {
redisLog(REDIS_WARNING, "--- CURRENT CLIENT INFO"); redisLog(REDIS_WARNING, "--- CURRENT CLIENT INFO");
client = getClientInfoString(cc); client = getClientInfoString(cc);
redisLog(REDIS_WARNING,"client: %s", client); redisLog(REDIS_WARNING,"client: %s", client);
/* Missing sdsfree(client) to avoid crash if memory is corrupted. */ sdsfree(client);
for (j = 0; j < cc->argc; j++) { for (j = 0; j < cc->argc; j++) {
robj *decoded; robj *decoded;
@ -631,6 +615,37 @@ void sigsegvHandler(int sig, siginfo_t *info, void *secret) {
} }
} }
void sigsegvHandler(int sig, siginfo_t *info, void *secret) {
ucontext_t *uc = (ucontext_t*) secret;
sds infostring, clients;
struct sigaction act;
REDIS_NOTUSED(info);
bugReportStart();
redisLog(REDIS_WARNING,
" Redis %s crashed by signal: %d", REDIS_VERSION, sig);
redisLog(REDIS_WARNING,
" Failed assertion: %s (%s:%d)", server.assert_failed,
server.assert_file, server.assert_line);
/* Log the stack trace */
logStackTrace(uc);
/* Log INFO and CLIENT LIST */
redisLog(REDIS_WARNING, "--- INFO OUTPUT");
infostring = genRedisInfoString("all");
infostring = sdscatprintf(infostring, "hash_init_value: %u\n",
dictGetHashFunctionSeed());
redisLogRaw(REDIS_WARNING, infostring);
redisLog(REDIS_WARNING, "--- CLIENT LIST OUTPUT");
clients = getAllClientsInfoString();
redisLogRaw(REDIS_WARNING, clients);
sdsfree(infostring);
sdsfree(clients);
/* Log the current client */
logCurrentClient();
/* Log dump of processor registers */ /* Log dump of processor registers */
logRegisters(uc); logRegisters(uc);