From 365e6c45ea0d5d9d72ac18b1df729f536c1fa0a1 Mon Sep 17 00:00:00 2001 From: heqin Date: Mon, 18 Dec 2017 17:59:03 +0800 Subject: [PATCH 1/2] fixbug for #4545 dead loop aof rewrite --- src/server.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/server.c b/src/server.c index b8f43b3a..f40a7be5 100644 --- a/src/server.c +++ b/src/server.c @@ -1119,7 +1119,9 @@ int serverCron(struct aeEventLoop *eventLoop, long long id, void *clientData) { } /* Trigger an AOF rewrite if needed */ - if (server.rdb_child_pid == -1 && + // If AOF disabled, we don't rewrite AOF file. + if (server.aof_fd != -1 && + server.rdb_child_pid == -1 && server.aof_child_pid == -1 && server.aof_rewrite_perc && server.aof_current_size > server.aof_rewrite_min_size) From 3d3faa0a190e3ad987613b4c3f853d9ffd38a237 Mon Sep 17 00:00:00 2001 From: heqin Date: Wed, 17 Jan 2018 18:08:30 +0800 Subject: [PATCH 2/2] fixbug for #4545 dead loop aof rewrite --- src/server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server.c b/src/server.c index f40a7be5..b144db02 100644 --- a/src/server.c +++ b/src/server.c @@ -1120,7 +1120,7 @@ int serverCron(struct aeEventLoop *eventLoop, long long id, void *clientData) { /* Trigger an AOF rewrite if needed */ // If AOF disabled, we don't rewrite AOF file. - if (server.aof_fd != -1 && + if (server.aof_state == AOF_ON && server.rdb_child_pid == -1 && server.aof_child_pid == -1 && server.aof_rewrite_perc &&