fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-04-03 16:21:03 +00:00
Code Issues Projects Releases Wiki Activity

redis-trib: initial working implementation of cluster rehashing, more work needed to make it more correct, more reliable.

Browse Source
This commit is contained in:
antirez 2011-09-30 22:18:07 +02:00
parent d38d2fdfdc
commit a0189bbe75
1 changed files with 26 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/redis-trib.rb
View File

@ -1,5 +1,12 @@
#!/usr/bin/env ruby #!/usr/bin/env ruby
# TODO (temporary here, we'll move this into the Github issues once redis-trib initial
# implementation is complted).
#
# - Make sure that if the rehashing fails in the middle redis-trib will try to recover.
# - When redis-trib performs a cluster check, if it detects a slot move in progress it
# should prompt the user to continue the move from where it stopped.
require 'rubygems' require 'rubygems'
require 'redis' require 'redis'
@ -318,14 +325,29 @@ class RedisTrib
} }
end end
def move_slot(source,target,slot) def move_slot(source,target,slot,o={})
# We start marking the slot as importing in the destination node, # We start marking the slot as importing in the destination node,
# and the slot as migrating in the target host. Note that the order of # and the slot as migrating in the target host. Note that the order of
# the operations is important, as otherwise a client may be redirected to # the operations is important, as otherwise a client may be redirected to
# the target node that does not yet know it is importing this slot. # the target node that does not yet know it is importing this slot.
target.r("cluster","setslot",slot,"importing",source.info[:name]) print "Moving slot #{slot}: "; STDOUT.flush
source.r("cluster","setslot",slot,"migrating",source.info[:name]) target.r.cluster("setslot",slot,"importing",source.info[:name])
source.r.cluster("setslot",slot,"migrating",source.info[:name])
# Migrate all the keys from source to target using the MIGRATE command # Migrate all the keys from source to target using the MIGRATE command
while true
keys = source.r.cluster("getkeysinslot",slot,10)
break if keys.length == 0
keys.each{|key|
source.r.migrate(target.info[:host],target.info[:port],key,0,1)
print "." if o[:verbose]
STDOUT.flush
}
end
puts
# Set the new node as the owner of the slot in all the known nodes.
@nodes.each{|n|
n.r.cluster("setslot",slot,"node",target.info[:name])
}
end end
# redis-trib subcommands implementations # redis-trib subcommands implementations
@ -396,7 +418,7 @@ class RedisTrib
yesno = STDIN.gets.chop yesno = STDIN.gets.chop
exit(1) if (yesno != "yes") exit(1) if (yesno != "yes")
reshard_table.each{|e| reshard_table.each{|e|
move_slot(e[:source],target,e[:slot]) move_slot(e[:source],target,e[:slot],:verbose=>true)
} }
end end