fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-03-31 14:51:04 +00:00
Code Issues Projects Releases Wiki Activity

overflow detection in INCR family functions

Browse Source
This commit is contained in:
antirez 2010-12-19 12:22:12 +01:00
parent 59aee5513d
commit 9d7165e885
1 changed files with 6 additions and 1 deletions

7
src/t_string.c

@ -346,14 +346,19 @@ void msetnxCommand(redisClient *c) {
} }
void incrDecrCommand(redisClient *c, long long incr) { void incrDecrCommand(redisClient *c, long long incr) {
long long value; long long value, oldvalue;
robj *o; robj *o;
o = lookupKeyWrite(c->db,c->argv[1]); o = lookupKeyWrite(c->db,c->argv[1]);
if (o != NULL && checkType(c,o,REDIS_STRING)) return; if (o != NULL && checkType(c,o,REDIS_STRING)) return;
if (getLongLongFromObjectOrReply(c,o,&value,NULL) != REDIS_OK) return; if (getLongLongFromObjectOrReply(c,o,&value,NULL) != REDIS_OK) return;
oldvalue = value;
value += incr; value += incr;
if ((incr < 0 && value > oldvalue) || (incr > 0 && value < oldvalue)) {
addReplyError(c,"increment or decrement would overflow");
return;
}
o = createStringObjectFromLongLong(value); o = createStringObjectFromLongLong(value);
dbReplace(c->db,c->argv[1],o); dbReplace(c->db,c->argv[1],o);
touchWatchedKey(c->db,c->argv[1]); touchWatchedKey(c->db,c->argv[1]);