fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-03-19 17:10:50 +00:00
Code Issues Projects Releases Wiki Activity

Change 42 to 1000 as warning level for cached scripts.

Browse Source 
Related to #4883.
This commit is contained in:
antirez 2018-07-23 18:44:38 +02:00
parent 445a2a2b1b
commit 9a375e5408
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/object.c
View File

@ -1138,8 +1138,8 @@ sds getMemoryDoctorReport(void) {
num_reports++; num_reports++;
} }
/* Too many (over 42) scripts are cached? */ /* Too many scripts are cached? */
if (dictSize(server.lua_scripts) > 42) { if (dictSize(server.lua_scripts) > 1000) {
many_scripts = 1; many_scripts = 1;
num_reports++; num_reports++;
} }
@ -1181,7 +1181,7 @@ sds getMemoryDoctorReport(void) {
s = sdscat(s," * Big client buffers: The clients output buffers in this instance are greater than 200K per client (on average). This may result from different causes, like Pub/Sub clients subscribed to channels bot not receiving data fast enough, so that data piles on the Redis instance output buffer, or clients sending commands with large replies or very large sequences of commands in the same pipeline. Please use the CLIENT LIST command in order to investigate the issue if it causes problems in your instance, or to understand better why certain clients are using a big amount of memory.\n\n"); s = sdscat(s," * Big client buffers: The clients output buffers in this instance are greater than 200K per client (on average). This may result from different causes, like Pub/Sub clients subscribed to channels bot not receiving data fast enough, so that data piles on the Redis instance output buffer, or clients sending commands with large replies or very large sequences of commands in the same pipeline. Please use the CLIENT LIST command in order to investigate the issue if it causes problems in your instance, or to understand better why certain clients are using a big amount of memory.\n\n");
} }
if (many_scripts) { if (many_scripts) {
s = sdscat(s," * Many scripts: There seem to be many cached scripts in this instance (more than 42). This may be because scripts are generated and `EVAL`ed, instead of being parameterized (with KEYS and ARGV), `SCRIPT LOAD`ed and `EVALSHA`ed. Unless `SCRIPT FLUSH` is called periodically, the scripts' caches may end up consuming most of your memory.\n\n"); s = sdscat(s," * Many scripts: There seem to be many cached scripts in this instance (more than 1000). This may be because scripts are generated and `EVAL`ed, instead of being parameterized (with KEYS and ARGV), `SCRIPT LOAD`ed and `EVALSHA`ed. Unless `SCRIPT FLUSH` is called periodically, the scripts' caches may end up consuming most of your memory.\n\n");
} }
s = sdscat(s,"I'm here to keep you safe, Sam. I want to help you.\n"); s = sdscat(s,"I'm here to keep you safe, Sam. I want to help you.\n");
} }