fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-04-11 19:56:03 +00:00
Code Issues Projects Releases Wiki Activity

Cluster: rebalance now supports --threshold option.

Browse Source
This commit is contained in:
antirez 2015-12-18 15:51:39 +01:00
parent 628af70214
commit 80b70371e8
1 changed files with 24 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/redis-trib.rb
View File

@ -913,7 +913,10 @@ class RedisTrib
end end
def rebalance_cluster_cmd(argv,opt) def rebalance_cluster_cmd(argv,opt)
opt = {'pipeline' => MigrateDefaultPipeline}.merge(opt) opt = {
'pipeline' => MigrateDefaultPipeline,
'threshold' => RebalanceDefaultThreshold
}.merge(opt)
# Load nodes info before parsing options, otherwise we can't # Load nodes info before parsing options, otherwise we can't
# handle --weight. # handle --weight.
@ -956,15 +959,34 @@ class RedisTrib
# Calculate the slots balance for each node. It's the number of # Calculate the slots balance for each node. It's the number of
# slots the node should lose (if positive) or gain (if negative) # slots the node should lose (if positive) or gain (if negative)
# in order to be balanced. # in order to be balanced.
threshold = opt['threshold'].to_f
threshold_reached = false
@nodes.each{|n| @nodes.each{|n|
if n.has_flag?("master") if n.has_flag?("master")
next if !n.info[:w] next if !n.info[:w]
expected = ((ClusterHashSlots.to_f / total_weight) * expected = ((ClusterHashSlots.to_f / total_weight) *
n.info[:w]).to_i n.info[:w]).to_i
n.info[:balance] = n.slots.length - expected n.info[:balance] = n.slots.length - expected
# Compute the percentage of difference between the
# expected number of slots and the real one, to see
# if it's over the threshold specified by the user.
over_threshold = false
if threshold > 0
if n.slots.length > 0
err_perc = (100-(100.0*expected/n.slots.length)).abs
over_threshold = true if err_perc > threshold
elsif expected > 0
over_threshold = true
end
end
puts "#{n} balance is #{n.info[:balance]} slots" if $verbose puts "#{n} balance is #{n.info[:balance]} slots" if $verbose
threshold_reached = true if over_threshold
end end
} }
if !threshold_reached
xputs "*** No rebalancing needed! All nodes are within the #{threshold}% threshold."
return
end
# Sort nodes by their slots balance. # Sort nodes by their slots balance.
sn = @nodes.select{|n| sn = @nodes.select{|n|
@ -1548,7 +1570,7 @@ ALLOWED_OPTIONS={
"add-node" => {"slave" => false, "master-id" => true}, "add-node" => {"slave" => false, "master-id" => true},
"import" => {"from" => :required, "copy" => false, "replace" => false}, "import" => {"from" => :required, "copy" => false, "replace" => false},
"reshard" => {"from" => true, "to" => true, "slots" => true, "yes" => false, "timeout" => true, "pipeline" => true}, "reshard" => {"from" => true, "to" => true, "slots" => true, "yes" => false, "timeout" => true, "pipeline" => true},
"rebalance" => {"weight" => [], "auto-weights" => false, "threshold" => RebalanceDefaultThreshold, "use-empty-masters" => false, "timeout" => true, "simulate" => false, "pipeline" => true}, "rebalance" => {"weight" => [], "auto-weights" => false, "threshold" => RebalanceDefaultThreshold, "use-empty-masters" => false, "timeout" => true, "simulate" => false, "pipeline" => true, "threshold" => true},
"fix" => {"timeout" => MigrateDefaultTimeout}, "fix" => {"timeout" => MigrateDefaultTimeout},
} }