fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-03-30 22:31:03 +00:00
Code Issues Projects Releases Wiki Activity

rename(2) used in diskstore.c for atomic updates of keys

Browse Source
This commit is contained in:
antirez 2011-01-04 18:28:04 +01:00
parent fad97fbeea
commit 779fa2af7a
1 changed files with 22 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/diskstore.c
View File

@ -141,12 +141,13 @@ int dsClose(void) {
} }
/* Convert key into full path for this object. Dirty but hopefully /* Convert key into full path for this object. Dirty but hopefully
* is fast enough. */ * is fast enough. Returns the length of the returned path. */
void dsKeyToPath(redisDb *db, char *buf, robj *key) { int dsKeyToPath(redisDb *db, char *buf, robj *key) {
SHA1_CTX ctx; SHA1_CTX ctx;
unsigned char hash[20]; unsigned char hash[20];
char hex[40], digits[] = "0123456789abcdef"; char hex[40], digits[] = "0123456789abcdef";
int j, l; int j, l;
char *origbuf = buf;
SHA1Init(&ctx); SHA1Init(&ctx);
SHA1Update(&ctx,key->ptr,sdslen(key->ptr)); SHA1Update(&ctx,key->ptr,sdslen(key->ptr));
@ -179,19 +180,33 @@ void dsKeyToPath(redisDb *db, char *buf, robj *key) {
buf[0] = '_'; buf[0] = '_';
memcpy(buf+1,hex,40); memcpy(buf+1,hex,40);
buf[41] = '\0'; buf[41] = '\0';
return (buf-origbuf)+41;
} }
int dsSet(redisDb *db, robj *key, robj *val) { int dsSet(redisDb *db, robj *key, robj *val) {
char buf[1024]; char buf[1024], buf2[1024];
FILE *fp; FILE *fp;
int retval; int retval, len;
dsKeyToPath(db,buf,key); len = dsKeyToPath(db,buf,key);
fp = fopen(buf,"w"); memcpy(buf2,buf,len);
snprintf(buf2+len,sizeof(buf2)-len,"%ld.%ld",(long)time(NULL),(long)val);
fp = fopen(buf2,"w");
if ((retval = rdbSaveKeyValuePair(fp,db,key,val,time(NULL))) == -1) if ((retval = rdbSaveKeyValuePair(fp,db,key,val,time(NULL))) == -1)
return REDIS_ERR; return REDIS_ERR;
fclose(fp); fclose(fp);
if (retval == 0) unlink(buf); /* Expired key. Unlink failing not critical */ if (retval == 0) {
/* Expired key. Unlink failing not critical */
unlink(buf);
unlink(buf2);
} else {
/* Use rename for atomic updadte of value */
if (rename(buf2,buf) == -1) {
redisLog(REDIS_WARNING,"rename(2) returned an error: %s",
strerror(errno));
redisPanic("Unrecoverable diskstore error. Exiting.");
}
}
return REDIS_OK; return REDIS_OK;
} }