fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-04-01 23:31:03 +00:00
Code Issues Projects Releases Wiki Activity

Sentinel: fixes inverted strcmp() test preventing config updates.

Browse Source 
The result of this one-char bug was pretty serious, if the new master
had the same port of the previous master, but just a different IP
address, non-leader Sentinels would not be able to recognize the
configuration change.

This commit fixes issue #1394.

Many thanks to @shanemadden that reported the bug and helped
investigating it.
This commit is contained in:
antirez 2013-11-25 10:57:20 +01:00
parent 8d547ebd56
commit 6f4fd55762
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/sentinel.c
View File

@ -2025,7 +2025,7 @@ void sentinelReceiveHelloMessages(redisAsyncContext *c, void *reply, void *privd
if (msgmaster->config_epoch < master_config_epoch) { if (msgmaster->config_epoch < master_config_epoch) {
msgmaster->config_epoch = master_config_epoch; msgmaster->config_epoch = master_config_epoch;
if (master_port != msgmaster->addr->port || if (master_port != msgmaster->addr->port ||
!strcmp(msgmaster->addr->ip, token[5])) strcmp(msgmaster->addr->ip, token[5]))
{ {
sentinelAddr *old_addr; sentinelAddr *old_addr;