fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-03-19 17:10:50 +00:00
Code Issues Projects Releases Wiki Activity

PSYNC2: safe free backlog when reach the time limit

Browse Source 
When we free the backlog, we should use a new
replication ID and clear the ID2. Since without
backlog we can not increment master_repl_offset
even do write commands, that may lead to inconsistency
when we try to connect a "slave-before" master
(if this master is our slave before, our replid
equals the master's replid2). As the master have our
history, so we can match the master's replid2 and
second_replid_offset, that make partial sync work,
but the data is inconsistent.
This commit is contained in:
zhaozhao.zz 2017-11-01 17:32:23 +08:00
parent 2bf8c2c130
commit 6ddf0ea293
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/replication.c
View File

@ -2613,6 +2613,18 @@ void replicationCron(void) {
time_t idle = server.unixtime - server.repl_no_slaves_since; time_t idle = server.unixtime - server.repl_no_slaves_since;
if (idle > server.repl_backlog_time_limit) { if (idle > server.repl_backlog_time_limit) {
/* When we free the backlog, we always use a new
* replication ID and clear the ID2. Since without
* backlog we can not increment master_repl_offset
* even do write commands, that may lead to inconsistency
* when we try to connect a "slave-before" master
* (if this master is our slave before, our replid
* equals the master's replid2). As the master have our
* history, so we can match the master's replid2 and
* second_replid_offset, that make partial sync work,
* but the data is inconsistent. */
changeReplicationId();
clearReplicationId2();
freeReplicationBacklog(); freeReplicationBacklog();
serverLog(LL_NOTICE, serverLog(LL_NOTICE,
"Replication backlog freed after %d seconds " "Replication backlog freed after %d seconds "