From 5b3d73b3d71fa8805af7677825cd5445f6a217ea Mon Sep 17 00:00:00 2001
From: Artix <artix2@gmail.com>
Date: Wed, 28 Feb 2018 15:21:08 +0100
Subject: [PATCH] Cluster Manager: fixed some memory error

---
 src/redis-cli.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/redis-cli.c b/src/redis-cli.c
index baaa615c..317b1125 100644
--- a/src/redis-cli.c
+++ b/src/redis-cli.c
@@ -2412,14 +2412,19 @@ static int clusterManagerSetSlot(clusterManagerNode *node1,
                                                 (char *) node2->name);
     if (err != NULL) *err = NULL;
     if (!reply) return 0;
+    int success = 1;
     if (reply->type == REDIS_REPLY_ERROR) {
+        success = 0;
         if (err != NULL) {
             *err = zmalloc((reply->len + 1) * sizeof(char));  
             strcpy(*err, reply->str); 
+            CLUSTER_MANAGER_PRINT_REPLY_ERROR(node1, err);
         }
-        return 0;
+        goto cleanup;
     }
-    return 1;
+cleanup:
+    freeReplyObject(reply);
+    return success;
 }
 
 static int clusterManagerMigrateKeysInSlot(clusterManagerNode *source, 
@@ -3175,7 +3180,7 @@ static list *clusterManagerComputeReshardTable(list *sources, int numslots) {
             int slot = node->slots[j];
             if (!slot) continue;
             if (count >= max || (int)listLength(moved) >= numslots) break;
-            clusterManagerReshardTableItem *item = zmalloc(sizeof(item));
+            clusterManagerReshardTableItem *item = zmalloc(sizeof(*item));
             item->source = node;
             item->slot = j;
             listAddNodeTail(moved, item);