fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-03-30 22:31:03 +00:00
Code Issues Projects Releases Wiki Activity

Handle large getrange requests

Browse Source 
Previously the end was casted to a smaller type
which resulted in a wrong check and failed
with values larger than handled by unsigned.

Closes #1847, #1844
This commit is contained in:
Jan-Erik Rediger 2014-06-29 12:32:06 +02:00 committed by antirez
parent f17f8521f0
commit 53fdfda9e3
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/t_string.c
View File

@ -255,7 +255,7 @@ void getrangeCommand(redisClient *c) {
if (end < 0) end = strlen+end; if (end < 0) end = strlen+end;
if (start < 0) start = 0; if (start < 0) start = 0;
if (end < 0) end = 0; if (end < 0) end = 0;
if ((unsigned)end >= strlen) end = strlen-1; if ((size_t)end >= strlen) end = strlen-1;
/* Precondition: end >= 0 && end < strlen, so the only condition where /* Precondition: end >= 0 && end < strlen, so the only condition where
* nothing can be returned is: start > end. */ * nothing can be returned is: start > end. */

5
tests/unit/basic.tcl
View File

@ -769,4 +769,9 @@ start_server {tags {"basic"}} {
r keys * r keys *
r keys * r keys *
} {dlskeriewrioeuwqoirueioqwrueoqwrueqw} } {dlskeriewrioeuwqoirueioqwrueoqwrueqw}
test {GETRANGE with huge ranges, Github issue #1844} {
r set foo bar
r getrange foo 0 4294967297
} {bar}
} }