From 3aa4b0097062b13031506b6b52fc8fc4bfec6dfc Mon Sep 17 00:00:00 2001
From: Pieter Noordhuis <pcnoordhuis@gmail.com>
Date: Wed, 17 Aug 2011 18:09:01 +0200
Subject: [PATCH] Failing test related to AOF rewrite buffers
---
tests/integration/aof-race.tcl | 35 ++++++++++++++++++++++++++++++++++
tests/test_helper.tcl | 1 +
2 files changed, 36 insertions(+)
create mode 100644 tests/integration/aof-race.tcl
diff --git a/tests/integration/aof-race.tcl b/tests/integration/aof-race.tcl
new file mode 100644
index 00000000..207f2073
--- /dev/null
+++ b/tests/integration/aof-race.tcl
@@ -0,0 +1,35 @@
+set defaults { appendonly {yes} appendfilename {appendonly.aof} }
+set server_path [tmpdir server.aof]
+set aof_path "$server_path/appendonly.aof"
+
+proc start_server_aof {overrides code} {
+ upvar defaults defaults srv srv server_path server_path
+ set config [concat $defaults $overrides]
+ start_server [list overrides $config] $code
+}
+
+tags {"aof"} {
+ # Specific test for a regression where internal buffers were not properly
+ # cleaned after a child responsible for an AOF rewrite exited. This buffer
+ # was subsequently appended to the new AOF, resulting in duplicate commands.
+ start_server_aof [list dir $server_path] {
+ set client [redis [srv host] [srv port]]
+ set bench [open "|src/redis-benchmark -q -p [srv port] -c 20 -n 20000 incr foo" "r+"]
+ after 100
+
+ # Benchmark should be running by now: start background rewrite
+ $client bgrewriteaof
+
+ # Read until benchmark pipe reaches EOF
+ while {[string length [read $bench]] > 0} {}
+
+ # Check contents of foo
+ assert_equal 20000 [$client get foo]
+ }
+
+ # Restart server to replay AOF
+ start_server_aof [list dir $server_path] {
+ set client [redis [srv host] [srv port]]
+ assert_equal 20000 [$client get foo]
+ }
+}
diff --git a/tests/test_helper.tcl b/tests/test_helper.tcl
index 4f3cf01e..476b5870 100644
--- a/tests/test_helper.tcl
+++ b/tests/test_helper.tcl
@@ -29,6 +29,7 @@ set ::all_tests {
integration/replication-2
integration/replication-3
integration/aof
+ integration/aof-race
unit/pubsub
unit/slowlog
unit/scripting