fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-03-30 22:31:03 +00:00
Code Issues Projects Releases Wiki Activity

Cluster: forced failover implemented.

Browse Source 
Using CLUSTER FAILOVER FORCE it is now possible to failover a master in
a forced way, which means:

1) No check to understand if the master is up is performed.
2) No data age of the slave is checked. Evan a slave with very old data
   can manually failover a master in this way.
3) No chat with the master is attempted to reach its replication offset:
   the master can just be down.
This commit is contained in:
antirez 2014-05-12 16:34:20 +02:00
parent 005f564eb3
commit 2692339138
1 changed files with 27 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/cluster.c
View File

@ -3646,13 +3646,27 @@ void clusterCommand(redisClient *c) {
addReplyBulkCString(c,ni); addReplyBulkCString(c,ni);
sdsfree(ni); sdsfree(ni);
} }
} else if (!strcasecmp(c->argv[1]->ptr,"failover") && c->argc == 2) { } else if (!strcasecmp(c->argv[1]->ptr,"failover") &&
/* CLUSTER FAILOVER */ (c->argc == 2 || c->argc == 3))
{
/* CLUSTER FAILOVER [FORCE] */
int force = 0;
if (c->argc == 3) {
if (!strcasecmp(c->argv[2]->ptr,"force")) {
force = 1;
} else {
addReply(c,shared.syntaxerr);
return;
}
}
if (nodeIsMaster(myself)) { if (nodeIsMaster(myself)) {
addReplyError(c,"You should send CLUSTER FAILOVER to a slave"); addReplyError(c,"You should send CLUSTER FAILOVER to a slave");
return; return;
} else if (myself->slaveof == NULL || nodeFailed(myself->slaveof) || } else if (!force &&
myself->slaveof->link == NULL) (myself->slaveof == NULL || nodeFailed(myself->slaveof) ||
myself->slaveof->link == NULL))
{ {
addReplyError(c,"Master is down or failed, " addReplyError(c,"Master is down or failed, "
"please use CLUSTER FAILOVER FORCE"); "please use CLUSTER FAILOVER FORCE");
@ -3660,7 +3674,15 @@ void clusterCommand(redisClient *c) {
} }
resetManualFailover(); resetManualFailover();
server.cluster->mf_end = mstime() + REDIS_CLUSTER_MF_TIMEOUT; server.cluster->mf_end = mstime() + REDIS_CLUSTER_MF_TIMEOUT;
clusterSendMFStart(myself->slaveof);
/* If this is a forced failover, we don't need to talk with our master
* to agree about the offset. We just failover taking over it without
* coordination. */
if (force) {
server.cluster->mf_can_start = 1;
} else {
clusterSendMFStart(myself->slaveof);
}
redisLog(REDIS_WARNING,"Manual failover user request accepted."); redisLog(REDIS_WARNING,"Manual failover user request accepted.");
addReply(c,shared.ok); addReply(c,shared.ok);
} else if (!strcasecmp(c->argv[1]->ptr,"set-config-epoch") && c->argc == 3) } else if (!strcasecmp(c->argv[1]->ptr,"set-config-epoch") && c->argc == 3)