fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-04-01 15:21:03 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #5806 from soloestoy/bugfix-acl-check-key-pattern

Browse Source 
Bugfix in ACLCheckCommandPerm
This commit is contained in:
Salvatore Sanfilippo 2019-01-25 13:00:17 +01:00 committed by GitHub
commit 1aa9fa37e3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/acl.c
View File

@ -555,7 +555,7 @@ int ACLCheckCommandPerm(client *c) {
for (int j = 0; j < numkeys; j++) { for (int j = 0; j < numkeys; j++) {
listIter li; listIter li;
listNode *ln; listNode *ln;
listRewind(u->passwords,&li); listRewind(u->patterns,&li);
/* Test this key against every pattern. */ /* Test this key against every pattern. */
int match = 0; int match = 0;
@ -570,9 +570,12 @@ int ACLCheckCommandPerm(client *c) {
break; break;
} }
} }
if (!match) return ACL_DENIED_KEY; if (!match) {
getKeysFreeResult(keyidx);
return ACL_DENIED_KEY;
}
} }
getKeysFreeResult(keyidx); if (keyidx) getKeysFreeResult(keyidx);
} }
/* If we survived all the above checks, the user can execute the /* If we survived all the above checks, the user can execute the