Cluster: resharding test provides more state when failing.

Now elements added to lists are incremental numbers in order to
understand, when inconsistencies are found, what is the order in which
the elements were added. Also the error now provides both the expected
and found value.
This commit is contained in:
antirez 2016-02-17 12:30:00 +01:00
parent b0ec22f948
commit 15f37ebd4a

View File

@ -59,6 +59,7 @@ array set content {}
set tribpid {} set tribpid {}
test "Cluster consistency during live resharding" { test "Cluster consistency during live resharding" {
set ele 0
for {set j 0} {$j < $numops} {incr j} { for {set j 0} {$j < $numops} {incr j} {
# Trigger the resharding once we execute half the ops. # Trigger the resharding once we execute half the ops.
if {$tribpid ne {} && if {$tribpid ne {} &&
@ -86,7 +87,7 @@ test "Cluster consistency during live resharding" {
# Write random data to random list. # Write random data to random list.
set listid [randomInt $numkeys] set listid [randomInt $numkeys]
set key "key:$listid" set key "key:$listid"
set ele [randomValue] incr ele
# We write both with Lua scripts and with plain commands. # We write both with Lua scripts and with plain commands.
# This way we are able to stress Lua -> Redis command invocation # This way we are able to stress Lua -> Redis command invocation
# as well, that has tests to prevent Lua to write into wrong # as well, that has tests to prevent Lua to write into wrong
@ -115,7 +116,9 @@ test "Cluster consistency during live resharding" {
test "Verify $numkeys keys for consistency with logical content" { test "Verify $numkeys keys for consistency with logical content" {
# Check that the Redis Cluster content matches our logical content. # Check that the Redis Cluster content matches our logical content.
foreach {key value} [array get content] { foreach {key value} [array get content] {
assert {[$cluster lrange $key 0 -1] eq $value} if {[$cluster lrange $key 0 -1] ne $value} {
fail "Key $key expected to hold '$value' but actual content is [$cluster lrange $key 0 -1]"
}
} }
} }
@ -133,7 +136,9 @@ test "Cluster should eventually be up again" {
test "Verify $numkeys keys after the crash & restart" { test "Verify $numkeys keys after the crash & restart" {
# Check that the Redis Cluster content matches our logical content. # Check that the Redis Cluster content matches our logical content.
foreach {key value} [array get content] { foreach {key value} [array get content] {
assert {[$cluster lrange $key 0 -1] eq $value} if {[$cluster lrange $key 0 -1] ne $value} {
fail "Key $key expected to hold '$value' but actual content is [$cluster lrange $key 0 -1]"
}
} }
} }