From 62015d4fb0805f350906b088a0c1036f8c5120cb Mon Sep 17 00:00:00 2001 From: Guy Korland Date: Thu, 13 Sep 2018 15:42:17 +0300 Subject: [PATCH 1/2] No need to return "OK" No need to return "+OK" in this case since the result is an Array of all the nodes --- src/modules/hellocluster.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/hellocluster.c b/src/modules/hellocluster.c index 75d18f3e..da3964d0 100644 --- a/src/modules/hellocluster.c +++ b/src/modules/hellocluster.c @@ -69,7 +69,7 @@ int ListCommand_RedisCommand(RedisModuleCtx *ctx, RedisModuleString **argv, int RedisModule_ReplyWithLongLong(ctx,port); } RedisModule_FreeClusterNodesList(ids); - return RedisModule_ReplyWithSimpleString(ctx, "OK"); + return REDISMODULE_OK; } /* Callback for message MSGTYPE_PING */ From b2fc998ad64d17ed8e1bb3d3fed9a2cd5815553d Mon Sep 17 00:00:00 2001 From: Guy Korland Date: Sun, 16 Sep 2018 15:21:21 +0300 Subject: [PATCH 2/2] typo fix --- src/modules/helloblock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/helloblock.c b/src/modules/helloblock.c index 6bba17d3..b90ccaa5 100644 --- a/src/modules/helloblock.c +++ b/src/modules/helloblock.c @@ -77,7 +77,7 @@ void *HelloBlock_ThreadMain(void *arg) { /* An example blocked client disconnection callback. * * Note that in the case of the HELLO.BLOCK command, the blocked client is now - * owned by the thread calling sleep(). In this speciifc case, there is not + * owned by the thread calling sleep(). In this specific case, there is not * much we can do, however normally we could instead implement a way to * signal the thread that the client disconnected, and sleep the specified * amount of seconds with a while loop calling sleep(1), so that once we