fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-04-03 08:11:03 +00:00
Code Issues Projects Releases Wiki Activity

Sentinel: handle Hello messages received via slaves correctly.

Browse Source 
Even when messages are received via the slave, we should perform
operations (like adding a new Sentinel) in the context of the master.
This commit is contained in:
antirez 2013-11-11 17:10:28 +01:00
parent 9e1b27d49e
commit 0bac36d0a1
1 changed files with 17 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/sentinel.c
View File

@ -1651,12 +1651,14 @@ void sentinelPublishReplyCallback(redisAsyncContext *c, void *reply, void *privd
/* This is our Pub/Sub callback for the Hello channel. It's useful in order /* This is our Pub/Sub callback for the Hello channel. It's useful in order
* to discover other sentinels attached at the same master. */ * to discover other sentinels attached at the same master. */
void sentinelReceiveHelloMessages(redisAsyncContext *c, void *reply, void *privdata) { void sentinelReceiveHelloMessages(redisAsyncContext *c, void *reply, void *privdata) {
sentinelRedisInstance *ri = c->data; sentinelRedisInstance *ri = c->data, *master;
redisReply *r; redisReply *r;
if (!reply || !ri) return; if (!reply || !ri) return;
r = reply; r = reply;
master = (ri->flags & SRI_MASTER) ? ri : ri->master;
/* Update the last activity in the pubsub channel. Note that since we /* Update the last activity in the pubsub channel. Note that since we
* receive our messages as well this timestamp can be used to detect * receive our messages as well this timestamp can be used to detect
* if the link is probably disconnected even if it seems otherwise. */ * if the link is probably disconnected even if it seems otherwise. */
@ -1691,26 +1693,26 @@ void sentinelReceiveHelloMessages(redisAsyncContext *c, void *reply, void *privd
master_port = atoi(token[7]); master_port = atoi(token[7]);
canfailover = atoi(token[3]); canfailover = atoi(token[3]);
si = getSentinelRedisInstanceByAddrAndRunID( si = getSentinelRedisInstanceByAddrAndRunID(
ri->sentinels,token[0],port,token[2]); master->sentinels,token[0],port,token[2]);
current_epoch = strtoull(token[4],NULL,10); current_epoch = strtoull(token[4],NULL,10);
master_config_epoch = strtoull(token[8],NULL,10); master_config_epoch = strtoull(token[8],NULL,10);
sentinelRedisInstance *master; sentinelRedisInstance *msgmaster;
if (!si) { if (!si) {
/* If not, remove all the sentinels that have the same runid /* If not, remove all the sentinels that have the same runid
* OR the same ip/port, because it's either a restart or a * OR the same ip/port, because it's either a restart or a
* network topology change. */ * network topology change. */
removed = removeMatchingSentinelsFromMaster(ri,token[0],port, removed = removeMatchingSentinelsFromMaster(master,token[0],port,
token[2]); token[2]);
if (removed) { if (removed) {
sentinelEvent(REDIS_NOTICE,"-dup-sentinel",ri, sentinelEvent(REDIS_NOTICE,"-dup-sentinel",master,
"%@ #duplicate of %s:%d or %s", "%@ #duplicate of %s:%d or %s",
token[0],port,token[2]); token[0],port,token[2]);
} }
/* Add the new sentinel. */ /* Add the new sentinel. */
si = createSentinelRedisInstance(NULL,SRI_SENTINEL, si = createSentinelRedisInstance(NULL,SRI_SENTINEL,
token[0],port,ri->quorum,ri); token[0],port,master->quorum,master);
if (si) { if (si) {
sentinelEvent(REDIS_NOTICE,"+sentinel",si,"%@"); sentinelEvent(REDIS_NOTICE,"+sentinel",si,"%@");
/* The runid is NULL after a new instance creation and /* The runid is NULL after a new instance creation and
@ -1725,17 +1727,18 @@ void sentinelReceiveHelloMessages(redisAsyncContext *c, void *reply, void *privd
sentinel.current_epoch = current_epoch; sentinel.current_epoch = current_epoch;
/* Update master info if received configuration is newer. */ /* Update master info if received configuration is newer. */
if ((master = sentinelGetMasterByName(token[5])) != NULL) { if ((msgmaster = sentinelGetMasterByName(token[5])) != NULL) {
if (master->config_epoch < master_config_epoch) { if (msgmaster->config_epoch < master_config_epoch) {
master->config_epoch = master_config_epoch; msgmaster->config_epoch = master_config_epoch;
if (master_port != master->addr->port || if (master_port != msgmaster->addr->port ||
!strcmp(master->addr->ip, token[6])) !strcmp(msgmaster->addr->ip, token[6]))
{ {
sentinelEvent(REDIS_WARNING,"+switch-master", sentinelEvent(REDIS_WARNING,"+switch-master",
master,"%s %s %d %s %d", msgmaster,"%s %s %d %s %d",
master->name, master->addr->ip, master->addr->port, msgmaster->name,
msgmaster->addr->ip, msgmaster->addr->port,
token[6], master_port); token[6], master_port);
sentinelResetMasterAndChangeAddress(ri, sentinelResetMasterAndChangeAddress(msgmaster,
token[6], master_port); token[6], master_port);
} }
} }