Merge branch 'unstable' of github.com:/antirez/redis into unstable

This commit is contained in:
antirez 2018-07-10 12:06:44 +02:00
commit 0420c3276f
6 changed files with 20 additions and 14 deletions

View File

@ -406,10 +406,13 @@ void handleClientsBlockedOnKeys(void) {
/* Lookup the consumer for the group, if any. */ /* Lookup the consumer for the group, if any. */
streamConsumer *consumer = NULL; streamConsumer *consumer = NULL;
int noack = 0;
if (group) { if (group) {
consumer = streamLookupConsumer(group, consumer = streamLookupConsumer(group,
receiver->bpop.xread_consumer->ptr, receiver->bpop.xread_consumer->ptr,
1); 1);
noack = receiver->bpop.xread_group_noack;
} }
/* Emit the two elements sub-array consisting of /* Emit the two elements sub-array consisting of
@ -426,7 +429,7 @@ void handleClientsBlockedOnKeys(void) {
}; };
streamReplyWithRange(receiver,s,&start,NULL, streamReplyWithRange(receiver,s,&start,NULL,
receiver->bpop.xread_count, receiver->bpop.xread_count,
0, group, consumer, 0, &pi); 0, group, consumer, noack, &pi);
/* Note that after we unblock the client, 'gt' /* Note that after we unblock the client, 'gt'
* and other receiver->bpop stuff are no longer * and other receiver->bpop stuff are no longer

View File

@ -140,6 +140,7 @@ client *createClient(int fd) {
c->bpop.target = NULL; c->bpop.target = NULL;
c->bpop.xread_group = NULL; c->bpop.xread_group = NULL;
c->bpop.xread_consumer = NULL; c->bpop.xread_consumer = NULL;
c->bpop.xread_group_noack = 0;
c->bpop.numreplicas = 0; c->bpop.numreplicas = 0;
c->bpop.reploffset = 0; c->bpop.reploffset = 0;
c->woff = 0; c->woff = 0;

View File

@ -665,6 +665,7 @@ typedef struct blockingState {
robj *xread_group; /* XREADGROUP group name. */ robj *xread_group; /* XREADGROUP group name. */
robj *xread_consumer; /* XREADGROUP consumer name. */ robj *xread_consumer; /* XREADGROUP consumer name. */
mstime_t xread_retry_time, xread_retry_ttl; mstime_t xread_retry_time, xread_retry_ttl;
int xread_group_noack;
/* BLOCKED_WAIT */ /* BLOCKED_WAIT */
int numreplicas; /* Number of replicas we are waiting for ACK. */ int numreplicas; /* Number of replicas we are waiting for ACK. */

View File

@ -1461,6 +1461,7 @@ void xreadCommand(client *c) {
incrRefCount(consumername); incrRefCount(consumername);
c->bpop.xread_group = groupname; c->bpop.xread_group = groupname;
c->bpop.xread_consumer = consumername; c->bpop.xread_consumer = consumername;
c->bpop.xread_group_noack = noack;
} else { } else {
c->bpop.xread_group = NULL; c->bpop.xread_group = NULL;
c->bpop.xread_consumer = NULL; c->bpop.xread_consumer = NULL;