From 03e2bb0cfd1ad6dba920e72b3d212cc3abb97d98 Mon Sep 17 00:00:00 2001 From: antirez Date: Tue, 11 Dec 2018 17:50:18 +0100 Subject: [PATCH] Crashing is too much in addReplyErrorLength(). See #5663. --- src/networking.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/networking.c b/src/networking.c index f19eb86b..74b857e0 100644 --- a/src/networking.c +++ b/src/networking.c @@ -372,12 +372,6 @@ void addReplyErrorLength(client *c, const char *s, size_t len) { serverLog(LL_WARNING,"== CRITICAL == This %s is sending an error " "to its %s: '%s' after processing the command " "'%s'", from, to, s, cmdname); - /* Here we want to panic because when a master is sending an - * error to some slave in the context of replication, this can - * only create some kind of offset or data desynchronization. Better - * to catch it ASAP and crash instead of continuing. */ - if (c->flags & CLIENT_SLAVE) - serverPanic("Continuing is unsafe: replication protocol violation."); } }