fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-04-03 00:01:04 +00:00
Code Issues Projects Releases Wiki Activity

Improved regression test for #4906.

Browse Source 
Removing the fix about 50% of the times the test will not be able to
pass cleanly. It's very hard to write a test that will always fail, or
actually, it is possible but then it's likely that it will consistently
pass if we change some random bit, so better to use randomization here.
This commit is contained in:
antirez 2018-06-11 13:10:03 +02:00
parent 27beaf2f22
commit 00613bed06
1 changed files with 38 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

68
tests/unit/scan.tcl
View File

@ -238,39 +238,47 @@ start_server {tags {"scan"}} {
} }
test "SCAN regression test for issue #4906" { test "SCAN regression test for issue #4906" {
r del set for {set k 0} {$k < 100} {incr k} {
set toremove {} r del set
array set found {} r sadd set x; # Make sure it's not intset encoded
for {set j 0} {$j < 500} {incr j} { set toremove {}
r sadd set $j unset -nocomplain found
if {$j >= 100} { array set found {}
lappend toremove $j
}
}
# Start scanning # Populate the set
set cursor 0 set numele [expr {100+[randomInt 1000]}]
set iteration 0 for {set j 0} {$j < $numele} {incr j} {
while {!($cursor == 0 && $iteration != 0)} { r sadd set $j
lassign [r sscan set $cursor] cursor items if {$j >= 100} {
lappend toremove $j
# Mark found items. We expect to find from 0 to 99 at the end }
# since those elements will never be removed during the scanning.
foreach i $items {
set found($i) 1
} }
incr iteration
# At some point remove most of the items to trigger the
# rehashing to a smaller hash table.
if {$iteration == 1} {
r srem set {*}$toremove
}
}
# Verify that SSCAN reported everything from 0 to 99 # Start scanning
for {set j 0} {$j < 100} {incr j} { set cursor 0
if {![info exists found($j)]} { set iteration 0
fail "SSCAN element missing $j" set del_iteration [randomInt 10]
while {!($cursor == 0 && $iteration != 0)} {
lassign [r sscan set $cursor] cursor items
# Mark found items. We expect to find from 0 to 99 at the end
# since those elements will never be removed during the scanning.
foreach i $items {
set found($i) 1
}
incr iteration
# At some point remove most of the items to trigger the
# rehashing to a smaller hash table.
if {$iteration == $del_iteration} {
r srem set {*}$toremove
}
}
# Verify that SSCAN reported everything from 0 to 99
for {set j 0} {$j < 100} {incr j} {
if {![info exists found($j)]} {
fail "SSCAN element missing $j"
}
} }
} }
} }