From 6d73ae765bedb3b9702784fc83d1b69262b96dfd Mon Sep 17 00:00:00 2001 From: Mike Voronov Date: Tue, 26 Apr 2022 16:23:03 +0300 Subject: [PATCH] add developer notes (#74) --- docs/developer-notes.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 docs/developer-notes.md diff --git a/docs/developer-notes.md b/docs/developer-notes.md new file mode 100644 index 0000000..fea8dde --- /dev/null +++ b/docs/developer-notes.md @@ -0,0 +1,5 @@ +In marine-rs-sdk we use the following conventions for PR reviewing: +- **Concept ACK** - agree with the idea and overall concept, but haven't reviewed the code changes or tested them, +- **utACK (untested ACK)** - reviewed and agree with the code changes but haven't actually tested them, +- **Tested ACK** - reviewed the code changes and have verified the functionality or a bug fix, +- **NACK** - disagree with the code changes/concept, should be accompanied by an explanation.